Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointer.dump should use StringBuilder instead of String concatenation #466

Closed
ck2510 opened this issue Jul 8, 2015 · 3 comments
Closed

Pointer.dump should use StringBuilder instead of String concatenation #466

ck2510 opened this issue Jul 8, 2015 · 3 comments
Labels
feature request

Comments

@ck2510
Copy link
Contributor

ck2510 commented Jul 8, 2015

The method's runtime does not scale. In my case dumping @1MB took more than 1 minute while a similar dump method based on StringBuilder returns "immediately".

If desired I will be happy to provide a patch with this change.
@dblock
Copy link
Member

dblock commented Jul 8, 2015

Please do contribute!

ck2510 added a commit to ck2510/jna that referenced this issue Oct 6, 2015
@ck2510
java-native-access#466: Improve performance of Pointer.dump for large…
274e312 
… dumps. Added simle unit test for Pointer.dump.
ck2510 added a commit to ck2510/jna that referenced this issue Oct 6, 2015
@ck2510
java-native-access#466: Improve performance of Pointer.dump for large…
7ff0c81 
… dumps. Added simle unit test for Pointer.dump.
@ck2510
Copy link
Contributor Author

ck2510 commented Oct 6, 2015

I created pull request #518 for this feature/improvement.

ck2510 added a commit to ck2510/jna that referenced this issue Apr 6, 2016
@ck2510
java-native-access#466: Improve performance of Pointer.dump for large…
f59704d 
… dumps. Pull and merge.
ck2510 added a commit to ck2510/jna that referenced this issue Apr 7, 2016
@ck2510
java-native-access#466: Improve performance of Pointer.dump for large…
6a9c1c9 
… dumps. Pull and merge.
twall added a commit that referenced this issue Apr 12, 2016
@twall
Merge pull request #518 from ck2510/master
dda206e 
#466: Improve performance of Pointer.dump for large dumps.
@matthiasblaesing
Copy link
Member

PR was merge by twall. Closing this.

mstyura pushed a commit to mstyura/jna that referenced this issue Sep 9, 2024
@normanmaurer
Upgrade to netty 4.1.87.Final (java-native-access#466)
843dd2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dblock @matthiasblaesing @ck2510