Structure leaves always one element in ThreadLocal set

[sjappig]

StructureSet does never remove the element at index 0:

public boolean remove(Object o) {
    int idx = indexOf(o);
    if (idx != -1) {
        if (--count > 0) {
            elements[idx] = elements[count];
            elements[count] = null;
        }
        return true;
    }
    return false;
}

Can be fixed by moving the null assign outside of the if-block or by changing the > to >=.

[twall]

Pull request and associated unit test are welcome. Confirmed by visual inspection and analysis, but I won’t be there for everyone’s build :)

On Mar 20, 2015, at 9:14 AM, Jari-Pekka Ryynänen [email protected] wrote:

StructureSet does never remove the element at index 0:

public boolean remove(Object
o) {

int idx =
indexOf(o);

if (idx != -1
) {

if (--count > 0
) {

elements[idx]

elements[count];
elements[count]
= null
;
}

return true
;
}

return false
;
}

Can be fixed by moving the null assign outside of the if-block or by changing the > to >=.

—
Reply to this email directly or view it on GitHub.