Why is there no 'SetSystemTime/SetLocalTime' declaration in Windows Kernel 32 wrapper ?

[lgoldstein]

I was wondering why the SetSystemTime API is not exposed in the Kernel32 wrapper - it seems to use the already existing SYSTEMTIME definition that is used for GetSystemTime. It does not seem to require any de-allocation of memory or such, so I was wondering if there is some special reason why this API was left out. It seems that all one has to is to add "boolean SetSystemTime/SetLocalTime(WinBase.SYSTEMTIME lpSystemTime)" definitions to the Kernel32 interface.

[dblock]

It has not been left out, nobody has contributed it. Please do. Don't forget tests.

[lgoldstein]

Here is a 'patch' file one can use in order to add the missing function - including unit test (sorry, don't have time for fork-modify-pullrequest-delete...)

From 0c10d71dab4115da244eb513ea4bc3f284b2ff00 Mon Sep 17 00:00:00 2001
From: Lyor Goldstein <[email protected]>
Date: Thu, 7 Aug 2014 09:46:06 +0300
Subject: [PATCH] Added Kernel32#SetSystemTime

---
 .../src/com/sun/jna/platform/win32/Kernel32.java   | 14 +++++++++
 .../com/sun/jna/platform/win32/Kernel32Test.java   | 34 ++++++++++++++++++++++
 2 files changed, 48 insertions(+)

diff --git a/contrib/platform/src/com/sun/jna/platform/win32/Kernel32.java b/contrib/platform/src/com/sun/jna/platform/win32/Kernel32.java
index b3b1604..06a6680 100644
--- a/contrib/platform/src/com/sun/jna/platform/win32/Kernel32.java
+++ b/contrib/platform/src/com/sun/jna/platform/win32/Kernel32.java
@@ -160,6 +160,20 @@ public interface Kernel32 extends WinNT {
     void GetSystemTime(WinBase.SYSTEMTIME lpSystemTime);

     /**
+     * The SetSystemTime function modifies the current system date and time.
+     * The system time is expressed in Coordinated Universal Time (UTC).
+     * 
+     * @param lpSystemTime
+     *            Pointer to a SYSTEMTIME structure holding the new
+     *            system date and time. <B>Note:</B> The {@code wDayOfWeek}
+     *            member of the SYSTEMTIME structure is ignored.
+     * @return {@code true} if the function succeeds, {@code false} otherwise.
+     *         If the function fails, call GetLastError to get extended error
+     *         information.
+     */
+    boolean SetSystemTime(WinBase.SYSTEMTIME lpSystemTime);
+
+    /**
      * Retrieves the current local date and time.
      * 
      * @param lpSystemTime
diff --git a/contrib/platform/test/com/sun/jna/platform/win32/Kernel32Test.java b/contrib/platform/test/com/sun/jna/platform/win32/Kernel32Test.java
index 699795c..840f970 100644
--- a/contrib/platform/test/com/sun/jna/platform/win32/Kernel32Test.java
+++ b/contrib/platform/test/com/sun/jna/platform/win32/Kernel32Test.java
@@ -78,6 +78,40 @@ public class Kernel32Test extends TestCase {
                      cal.get(Calendar.YEAR), time.wYear);
     }

+    public void testSetSystemTime() {
+        Kernel32 kernel = Kernel32.INSTANCE;
+        WinBase.SYSTEMTIME time = new WinBase.SYSTEMTIME();
+        kernel.GetSystemTime(time);
+        try {
+            WinBase.SYSTEMTIME expected = new WinBase.SYSTEMTIME();
+            expected.wYear = time.wYear;
+            expected.wMonth = time.wMonth;
+            expected.wDay = time.wDay;
+            expected.wHour = time.wHour;
+            expected.wMinute = time.wMinute;
+            expected.wSecond = time.wSecond;
+            expected.wMilliseconds = time.wMilliseconds;
+
+            if (expected.wHour > 0) {
+                expected.wHour--;
+            } else {
+                expected.wHour++;
+            }
+
+            if (!kernel.SetSystemTime(expected)) {
+                fail("Failed to modify time: error=" + kernel.GetLastError());
+            }
+            
+            WinBase.SYSTEMTIME actual = new WinBase.SYSTEMTIME();
+            kernel.GetSystemTime(actual);
+            assertEquals("Mismatched hour value", expected.wHour, actual.wHour);
+        } finally {
+            if (!kernel.SetSystemTime(time)) {
+                fail("Failed to restore original time: error=" + kernel.GetLastError());
+            }
+        }
+    }
+
     public void testGetLastError() {
         Kernel32 kernel = Kernel32.INSTANCE;
         int ERRCODE  = 8;
-- 
1.9.0.msysgit.0

[dblock]

Someone needs to turn this into a PR, thx.

[lgoldstein]

@dblock If you save it as .patch or .diff file, you can easily apply it via git or even the Linux patch command (or similar)

[dblock]

Should I send the bill for my time at my usual rate to VMWare? ;)

[lgoldstein]

@dblock I am merely trying to contribute something within the time constraints I have. Perhaps some other good samaritan can do the merging...

[thomasjoulin]

Here you go #357

Thanks @lgoldstein and @dblock :)

[twall]

thanks Thomas!

On Aug 7, 2014, at 7:27 AM, Thomas Joulin [email protected] wrote:

Here you go #357

Thanks @lgoldstein and @dblock :)

—
Reply to this email directly or view it on GitHub.

[dblock]

Thanks for jumping in @thomasjoulin, much appreciated. Merged via ef71874.

[lgoldstein]

Thanks @thomasjoulin and @dblock - looking forward to next release that will include it...