Document warning configuration and fix strdup (#define based on compi…

…ler)

native/Makefile

@@ -85,6 +85,14 @@ CC=gcc
 LD=$(CC)
 LIBS=
 # CC_OPTS only applied to objects build for jnidispatch, not for libffi
+# -Wno-unknown-warning-option 
+#                => Suppress warning for unknown warnings (CLANG)
+# -Werror        => Treat warnings as errors
+# -Wno-clobbered => Silence GCC warning about clobbered automatic variables.
+#                   The "longjmp" case only happens in protect.h in the logic
+#                   that implements "protected" mode. In that case an exception
+#                   is raised and the value of the potentially clobbered
+#                   variables is ignored.
 LOC_CC_OPTS=-Wno-unknown-warning-option -Werror -Wno-clobbered
 # Default to Sun recommendations for JNI compilation
 COPT=-O2 -fno-omit-frame-pointer -fno-strict-aliasing

native/dispatch.c

@@ -1116,7 +1116,7 @@ initializeThread(callback* cb, AttachOptions* args) {
       if (args->name != NULL) {
         // Make a copy, since the Java Structure which owns this native memory
         // will go out of scope and be available for GC
-        args->name = strdup(args->name);
+        args->name = STRDUP(args->name);
       }
     }
   }

native/dispatch.h

@@ -30,7 +30,6 @@
 #pragma warning( disable : 4204 ) /* structure initializer */
 #pragma warning( disable : 4710 ) /* swprintf not inlined */
 #pragma warning( disable : 4201 ) /* nameless struct/union (jni_md.h) */
-#pragma warning( disable : 4996 ) /* deprecated functions (strdup) */
 #else
 #include <malloc.h>
 #endif /* _MSC_VER */
@@ -145,7 +144,7 @@ typedef struct _callback {
 
 #if defined(_MSC_VER)
 #include "snprintf.h"
-#define strdup _strdup
+#define STRDUP _strdup
 #if defined(_WIN64)
 #define L2A(X) ((void *)(X))
 #define A2L(X) ((jlong)(X))
@@ -155,6 +154,7 @@ typedef struct _callback {
 #endif
 #else
 #include <stdio.h>
+#define STRDUP strdup
 #endif
 
 /* Convenience macros */