Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added/fixed support for the timeout option so the documentation in th… #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peppyheppy
Copy link

I noticed that the read timeout option specified in the README was not working as expected so I passed through the timeout option to make the README correct and the read timeout functional.

I added two tests and tested it out manually. Timeouts are hard to test but I think this will work.

Feedback welcome!

@peppyheppy
Copy link
Author

@waterlink, I noticed you were the newest maintainer and did a release recently. I also noticed that there were 10+ pull requests that were waiting review. Do you plan on reviewing the contributions? Will this pull request be reviewed or should I plan on using my fork?

Thank you!

Paul

@waterlink
Copy link
Contributor

Yes, I will go through all of them on Saturday (don't have laptop now).
On Jun 23, 2015 5:16 PM, "Paul Hepworth" [email protected] wrote:

@waterlink https://github.com/waterlink, I noticed you were the newest
maintainer and did a release recently. I also noticed that there were 10+
pull requests that were waiting review. Do you plan on reviewing the
contributions? Will this pull request be reviewed or should I plan on using
my fork?

Thank you!

Paul


Reply to this email directly or view it on GitHub
#52 (comment)
.

@peppyheppy
Copy link
Author

Thank you @waterlink ! Let me know if I can help.

@waterlink
Copy link
Contributor

@peppyheppy Merged here: waterlink/rack-reverse-proxy#1 (repo is moved, now waterlink/rack-reverse-proxy is main one).

bethesque pushed a commit to bethesque/rack-reverse-proxy that referenced this pull request Aug 3, 2017
new stripped_headers option & retire preserve_encoding option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants