New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-underscore header names provided by Rack #42

Open

kainosnoema wants to merge 1 commit into jaswope:master from cotap:fix/header-support

kainosnoema commented Jul 25, 2014

This fixes two problems:

This will now properly convert underscored header names to their dashed equivalent. Custom headers like Content-MD5 turns into HTTP_CONTENT_MD5 in Rack, so converting back from CONTENT_MD5 to CONTENT-MD5 is required.
Sometimes Rack's header values are nil. The one I've encountered so far using Rails in development is Origin. This will only set the header if the value is non-nil.


          Un-underscore header names provided by Rack

6db1d52

Signed-off-by: Evan Owen <[email protected]>

emilianogfcm commented Nov 26, 2014

You can do a release for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet