hide status bar item when no CODEOWNERS file #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If: - you have a multi-root workspace - one workspace has CODEOWNERS, the other doesn't Then when you switch to the one that doesn't, the status bar item will remain and give incorrect information. Fix this by hiding the status bar item when there is no CODEOWNERS file nearby.
|
Hey @jasonnutter, I'm thinking I might just fork this package - I'm excited about building out this package more, and I don't mind doing the extra maintenance work. Would you mind especially? |
|
Whoa sorry I somehow totally missed these PRs, apologies about that! I'll take a look shortly. You certainly don't need my permission to fork, but I'd also be happy to add you as a contributor. |
jasonnutter
approved these changes
Jul 25, 2019
|
Ah, no worries then! Sorry, I thought you had seen my commit but weren't interested in maintaining this extension. I'm fine with still merging into this package - best to have only one package to choose from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If:
Then when you switch to the one that doesn't, the status bar item will
remain and give incorrect information.
Fix this by hiding the status bar item when there is no CODEOWNERS file
nearby.
Before
After