add syntax highlighting #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- README.md: add screenshot - language-configuration.json: make `⌘ /` work on CODEOWNERS files - package.json: add file name association - codeowners.tmLanguage.json: add the actual syntax highlighting!
|
I was on vacation and totally missed this, sorry about that! 1 minor comment, otherwise looks great, thanks for the contribution! |
|
Thanks for taking a look. But uh... what is the 1 minor comment? I think you forgot to post it. |
|
Oh whoops, I started a review but didn't submit it...was a small comment, which you can disregard. Will merge, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey man, nice extension!
I was planning on writing an extension to add syntax highlighting to CODEOWNERS files. But since you already have an extension relating to CODEOWNERS, I figured it could just be added to your extension. Why create extra confusion with two competing extensions?
Anyway, let me know what you think, or if you want anything changed.
⌘ /work on CODEOWNERS files