Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Cooldown-Types #84

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Added Cooldown-Types #84

wants to merge 25 commits into from

Conversation

DenuxPlays
Copy link
Collaborator

@DenuxPlays DenuxPlays commented Nov 15, 2022 •
edited
Loading

This PR also fixes an issue where the old COOLDOWN_CACHE Map would not get rid of cooldowns that are already expired.

Hierarchy:
image

Closes: #72

@DenuxPlays DenuxPlays marked this pull request as draft November 15, 2022 20:13
@DenuxPlays DenuxPlays self-assigned this Nov 15, 2022
@DenuxPlays DenuxPlays added the new feature New feature (request). label Nov 15, 2022
@DenuxPlays DenuxPlays marked this pull request as ready for review November 16, 2022 18:49
@DenuxPlays
Copy link
Collaborator Author

@DynxstyGIT I do not like the current implementation but it works for now!
You decide wheter this pr gets merged or closed. (If closed please do not delete the branch!)

@DenuxPlays DenuxPlays marked this pull request as draft November 18, 2022 12:50
@DenuxPlays DenuxPlays added the blocked Blocked by something. label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonlessenich jasonlessenich Awaiting requested review from jasonlessenich

Assignees

@DenuxPlays DenuxPlays

Labels
blocked Blocked by something. new feature New feature (request).
Projects
None yet
Milestone
v1.7 – Text- & Hybrid Commands
Development

Successfully merging this pull request may close these issues.

Cooldown Types
2 participants
@DenuxPlays @jasonlessenich