Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TouchableWithoutFeedback accessible prop to be overwritten #84

Merged
merged 5 commits into from
Jun 10, 2020

Conversation

emmajoneshappl
Copy link

@emmajoneshappl emmajoneshappl commented Jun 4, 2020

We wanted to add accessibility props to the content in a tooltip.

To do this we needed to set the root TouchableWithoutFeedback accessible prop to false to prevent its children being grouped into a single selectable component (see https://reactnative.dev/docs/accessibility#accessible-android-ios).

I've added an accessible prop, keeping the default astrue.

@emmajoneshappl emmajoneshappl changed the title Allow TouchableWithoutFeedback accessible to be overwritten Allow TouchableWithoutFeedback accessible prop to be overwritten Jun 4, 2020
@jasongaare
Copy link
Owner

Looks great! Thanks for going this, and thanks for updating the README 🎉

Small request: the rest of the props in the table are sorted alphabetically - would make a change and bump accessible to the top? Thanks!

@emmajoneshappl
Copy link
Author

Small request: the rest of the props in the table are sorted alphabetically - would make a change and bump accessible to the top? Thanks!

@jasongaare Yes, have moved to the top. Thanks :)

@jasongaare jasongaare merged commit b544c55 into jasongaare:master Jun 10, 2020
@jasongaare
Copy link
Owner

@netemmajones I merged this and published in version 1.1.8 but I wasn't sure if the changes from #80 that also got merged would require any changes to your PR? namely, the addition of another touchable wrapping this.props.content

@emmajoneshappl
Copy link
Author

@netemmajones I merged this and published in version 1.1.8 but I wasn't sure if the changes from #80 that also got merged would require any changes to your PR? namely, the addition of another touchable wrapping this.props.content

@jasongaare Yes possibly, I will check and send a new PR if it does. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants