Mutliple tooltip enhancements #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch to fire onClose when when the background is tapped * Switch to allow background interactions * Switch to prevent users from closing the tooltip but not actually interacting with the child content
Reduce number of times we measure the UI elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jasongaare!
Thank you for this wonderful little tooltip library! We're going to use it in our app and needed a few tweaks to make it work the way we needed. I tried to keep the behavior of the tooltip the same and added some additional properties to control the new functionality.
placement !== 'top'Please let me know if you'd like any changes or think something shouldn't be part of this library. 💃🏻