Merge pull request #56 from jasongaare/bug/measurement-layout-loop

prevent update geometry getting called in a loop on some devices
jasongaare · Oct 10, 2019 · 9944994 · 9944994
2 parents 2c5e3f9 + 68def60
commit 9944994
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-walkthrough-tooltip",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "An inline wrapper for calling out React Native components via tooltip",
   "main": "src/tooltip.js",
   "scripts": {

diff --git a/src/tooltip.js b/src/tooltip.js
@@ -223,10 +223,6 @@ class Tooltip extends Component {
     this.setState({ contentSize }, () => {
       this._updateGeometry();
     });
-
-    if (React.Children.count(this.props.children) === 0) {
-      this.doChildlessPlacement();
-    }
   };
 
   onChildMeasurementComplete = (rect) => {
@@ -237,7 +233,9 @@ class Tooltip extends Component {
       },
       () => {
         this.isMeasuringChild = false;
-        this._updateGeometry();
+        if (this.state.contentSize.width) {
+          this._updateGeometry();
+        }
       }
     );
   };