🐛: Use onKeyDown in SearchBar to allow for simpler iteration of resul…

…ts (firefox-devtools#4533) In the QuickOpenModal we found that using onKeyDown meant a user could hold up/down to traverse their results more easily. In the searchbar holding enter does the same. Closes firefox-devtools#2527
jasonLaster · Nov 16, 2017 · a678afd · a678afd
1 parent a1877f4
commit a678afd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/Editor/SearchBar.js b/src/components/Editor/SearchBar.js
@@ -200,7 +200,7 @@ class SearchBar extends Component<Props, State> {
     return this.doSearch(e.target.value);
   };
 
-  onKeyUp = (e: SyntheticKeyboardEvent<HTMLElement>) => {
+  onKeyDown = (e: SyntheticKeyboardEvent<HTMLElement>) => {
     if (e.key !== "Enter" && e.key !== "F3") {
       return;
     }
@@ -288,7 +288,7 @@ class SearchBar extends Component<Props, State> {
           placeholder={L10N.getStr("sourceSearch.search.placeholder")}
           summaryMsg={this.buildSummaryMsg()}
           onChange={this.onChange}
-          onKeyUp={this.onKeyUp}
+          onKeyDown={this.onKeyDown}
           handleNext={e => this.traverseResults(e, false)}
           handlePrev={e => this.traverseResults(e, true)}
           handleClose={this.closeSearch}

diff --git a/src/components/Editor/tests/__snapshots__/SearchBar.spec.js.snap b/src/components/Editor/tests/__snapshots__/SearchBar.spec.js.snap
@@ -9,7 +9,7 @@ exports[`SearchBar should render 1`] = `
     handleNext={[Function]}
     handlePrev={[Function]}
     onChange={[Function]}
-    onKeyUp={[Function]}
+    onKeyDown={[Function]}
     placeholder="Search in file…"
     query=""
     showErrorEmoji={true}