Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a few more changes to the 1.7.0 changelog #1831

Merged
merged 1 commit into from
Sep 8, 2014

Conversation

akre54
Copy link
Collaborator

@akre54 akre54 commented Sep 3, 2014

No description provided.

@@ -2067,6 +2067,20 @@ <h2 id="changelog">Change Log</h2>
<tt>_.has</tt> now guards against nullish objects.
</li>
<li>
Aligning better with the forthcoming ECMA6 <tt>Object.assign</tt>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES6 or ECMA262 edition 6 or something, but not ECMA6.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECMAScript 5 and ES5 are also used, I just picked one that worked here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaahh let's change those.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@megawac
Copy link
Collaborator

megawac commented Sep 3, 2014

Couple others from my list

@jdalton
Copy link
Contributor

jdalton commented Sep 3, 2014

  • _.flatten no longer works on objects
    (it was an undocumented side affect of previously using _.each in its implementation)
  • _.matches now iterates over own properties of the source object

@akre54
Copy link
Collaborator Author

akre54 commented Sep 3, 2014

var a = _(), b = a.chain() doesn't create 2 instances of _

Is this public-facing though? Would this be breaking for anything?

_.flatten no longer works on objects

This should be fine since _.flatten is an arrays method and it wouldn't be expected to work with objects.

union and difference exclude non arrays

underscore/index.html

Lines 2078 to 2079 in 5b0152c

For consistency, <tt>_.union</tt> and <tt>_.difference</tt> now
only work with arrays and not variadic args.

I'll grab the rest.

@akre54 akre54 force-pushed the doc-updates branch 2 times, most recently from ddee4c8 to f3e66dd Compare September 3, 2014 18:17
@megawac megawac added the docs label Sep 4, 2014
@akre54 akre54 force-pushed the doc-updates branch 2 times, most recently from 32abe28 to 73bcbf7 Compare September 4, 2014 17:01
@megawac
Copy link
Collaborator

megawac commented Sep 8, 2014

👍

@akre54
Copy link
Collaborator Author

akre54 commented Sep 8, 2014

Cool, wanna do the honors?

@jdalton
Copy link
Contributor

jdalton commented Sep 8, 2014

This should be fine since _.flatten is an arrays method and it wouldn't be expected to work with objects.

It was reported here so figured I'd pass it along.

@megawac megawac merged commit d36a843 into jashkenas:master Sep 8, 2014
@jdalton jdalton mentioned this pull request Sep 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants