Matches keeps an internal reference to spec object #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1178,13 +1178,13 @@ | |||
|
|
|||
| // Returns a predicate for checking whether an object has a given set of `key:value` pairs. | |||
| _.matches = function(attrs) { | |||
| var keys = _.keys(attrs), length = keys.length; | |||
| var pairs = _.pairs(attrs), length = pairs.length; | |||
| return function(obj) { | |||
| if (obj === attrs) return true; | |||
There was a problem hiding this comment.
How common is obj === attrs really? I assume not so very common so seems like an extraneous check.
There was a problem hiding this comment.
Let's open a separate PR for that.
|
LGTM. Thanks. |
michaelficarra
added a commit
that referenced
this pull request
Jul 9, 2014
Matches keeps an internal reference to spec object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1729