UMD-ready Underscore #1303
Closed
UMD-ready Underscore #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A stub `noConflict` function is provided in Underscore.js to retain API compatibility. The real `noConflict` method is only defined once if Underscore.js is not loaded as-is in the browser (ie. as an AMD-module or in a Node.js environment).
|
Well, it's a patch over the 1.5.2 tag but it should rebase nicely on master too. |
|
HI. |
|
Thanks for the pointer, did not see it! Though Backbone has been updated since and if |
|
Nevermind my previous comment, it is only a partial response to the issue pointed out by @Delapouite . |
|
My apologies, @jashkenas made it clear in /pull/431. edit: if anyone is interested in using an AMD-compatible version of jashkenas/underscore still backwards compatible, one can fork jrburke/underscore@alwaysglobal and fast-forward the updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underscore.js is now an UMD module.
The UMD definition is based on https://github.com/umdjs/umd/blob/master/returnExports.js.
A stub
noConflictfunction is provided in Underscore.js to retain API compatibility.The real
noConflictmethod is only defined once if Underscore.js is not loaded as-is in the browser (ie. as an AMD-module or in a Node.js environment).