Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2] Throw an error for ambiguous get or set keywords or function calls #4484

Merged
merged 10 commits into from
Apr 9, 2017
Merged

[CS2] Throw an error for ambiguous get or set keywords or function calls #4484

merged 10 commits into from
Apr 9, 2017

Commits on Apr 4, 2017

  1. Throw an error for ambiguous get or set function calls or ES5 get… 

    …ter/setter keywords, to warn the user to use parentheses if they intend a function call (or to inform them that `get` or `set` cannot be used as a keyword)
    @GeoffreyBooth
    GeoffreyBooth committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    5596dac View commit details
    Browse the repository at this point in the history

  2. Code golf

    @GeoffreyBooth
    GeoffreyBooth committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    725fe8e View commit details
    Browse the repository at this point in the history

  3. Catch get or set keyword before static method

    @GeoffreyBooth
    GeoffreyBooth committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    fcf7dda View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2017

  1. DRY up getting the previous token

    @GeoffreyBooth
    GeoffreyBooth committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    ed4c828 View commit details
    Browse the repository at this point in the history

  2. Throw an error if get or set are used as keywords before what looks l… 

    …ike a function or method with an interpolated/dynamic name
    @GeoffreyBooth
    GeoffreyBooth committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    962374a View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2017

  1. Allow get or set parentheses-less function calls when first argum… 

    …ent is a string without a colon (so a plain string, not a property accessor)
    @GeoffreyBooth
    GeoffreyBooth committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    2d1addf View commit details
    Browse the repository at this point in the history

  2. Revert "Allow get or set parentheses-less function calls when fir… 

    …st argument is a string without a colon (so a plain string, not a property accessor)"

This reverts commit 2d1addf.
    @GeoffreyBooth
    GeoffreyBooth committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    a7447d5 View commit details
    Browse the repository at this point in the history

  3. Optimization

    @GeoffreyBooth
    GeoffreyBooth committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    4d25907 View commit details
    Browse the repository at this point in the history

  4. Merge branch '2' into get-set-warning 

    # Conflicts:
#	lib/coffeescript/lexer.js
    @GeoffreyBooth
    GeoffreyBooth committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    7129f83 View commit details
    Browse the repository at this point in the history

  5. No longer throw an error on get or set function calls to objects … 

    …with dynamic property names (introduces a way to circumvent our check for trying to avoid the `get` or `set` keywords, but not worth the complications for this tiny edge case)
    @GeoffreyBooth
    GeoffreyBooth committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    0576eb3 View commit details
    Browse the repository at this point in the history