Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 1.12.0 #4381

Merged
merged 18 commits into from
Dec 4, 2016
Merged

[WIP] 1.12.0 #4381

merged 18 commits into from
Dec 4, 2016

Conversation

GeoffreyBooth
Copy link
Collaborator

@jashkenas @lydell I think we’re ready for 1.12.0.

Besides the updated lib folder, browser compiler, docs, annotated source and change log, I snuck in a few more documentation improvements:

  • Docs examples with quotation marks are fixed. (Try running tim.age + " " + tim.height on the current http://coffeescript.org.) Now Cakefile properly escapes the quotes.
  • Eligible HTML entities (basically, anything other than &, < or >) are now written as unicode characters, a recommended practice.
  • Along those lines, quotation marks in regular text are now curly. Ellipses when used as text and not as splat code are now ellipses characters.
  • A link to the browser tests (test.html) was added under Resources.

@@ -193,6 +190,27 @@
<div class="pilwrap ">
<a class="pilcrow" href="#section-5">&#182;</a>
</div>
<p>The contents of a <script> block are encoded via UTF-16, so if any extended
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't <script> use escaped <> here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess docco lets html fall through...

Copy link
Collaborator Author

@GeoffreyBooth GeoffreyBooth Dec 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping the HTML in backticks fixes this. Once #4383 is merged in, I’ll regenerate the compiler and annotated source.

@greghuc
Copy link
Contributor

greghuc commented Dec 1, 2016

@GeoffreyBooth I believe 1.12.0 will be affected by the just-reported 'unescaped backticks in interpolated strings' bug, though only if someone uses tagged template literals. I'll have a fix in the next few days.

<li>
CoffeeScript’s <a href="#objects_and_arrays">shorthand object
notation</a> is finally documented.
</li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, all the documentation or build system improvement points (such as this one) are just noise in the change log. It’s really awesome work, but not needed to be in the change log. Again, that’s my opinion. :)

@lydell
Copy link
Collaborator

lydell commented Dec 1, 2016

I agree that the 'unescaped backticks in interpolated strings' bug has to be fixed before a release.

@GeoffreyBooth GeoffreyBooth changed the title 1.12.0 [WIP] 1.12.0 Dec 2, 2016
@GeoffreyBooth
Copy link
Collaborator Author

Updated with #4383. How about now?

@lydell
Copy link
Collaborator

lydell commented Dec 4, 2016

Everything looks good to me! 👍 Nice work.

@GeoffreyBooth
Copy link
Collaborator Author

Thanks. I don't have access to NPM. @lydell, can you deploy to there and then accept this PR?

@lydell lydell merged commit fb0639f into jashkenas:master Dec 4, 2016
@lydell lydell deleted the 1.12 branch December 4, 2016 19:32
@lydell
Copy link
Collaborator

lydell commented Dec 4, 2016

Done.

@greghuc
Copy link
Contributor

greghuc commented Dec 4, 2016

@GeoffreyBooth and everyone else involved - congrats on getting 1.12 out. Looking forward to Coffeescript 2 :-)

@GeoffreyBooth
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants