-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] 1.12.0 #4381
[WIP] 1.12.0 #4381
Conversation
…ractice: http://stackoverflow.com/a/436637/223225) and convert straight quotes to curly quotes
@@ -193,6 +190,27 @@ | |||
<div class="pilwrap "> | |||
<a class="pilcrow" href="#section-5">¶</a> | |||
</div> | |||
<p>The contents of a <script> block are encoded via UTF-16, so if any extended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't <script>
use escaped <> here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess docco lets html fall through...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping the HTML in backticks fixes this. Once #4383 is merged in, I’ll regenerate the compiler and annotated source.
@GeoffreyBooth I believe 1.12.0 will be affected by the just-reported 'unescaped backticks in interpolated strings' bug, though only if someone uses tagged template literals. I'll have a fix in the next few days. |
<li> | ||
CoffeeScript’s <a href="#objects_and_arrays">shorthand object | ||
notation</a> is finally documented. | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, all the documentation or build system improvement points (such as this one) are just noise in the change log. It’s really awesome work, but not needed to be in the change log. Again, that’s my opinion. :)
I agree that the 'unescaped backticks in interpolated strings' bug has to be fixed before a release. |
Updated with #4383. How about now? |
Everything looks good to me! 👍 Nice work. |
Thanks. I don't have access to NPM. @lydell, can you deploy to there and then accept this PR? |
Done. |
@GeoffreyBooth and everyone else involved - congrats on getting 1.12 out. Looking forward to Coffeescript 2 :-) |
Thanks! |
@jashkenas @lydell I think we’re ready for 1.12.0.
Besides the updated
lib
folder, browser compiler, docs, annotated source and change log, I snuck in a few more documentation improvements:tim.age + " " + tim.height
on the current http://coffeescript.org.) NowCakefile
properly escapes the quotes.&
,<
or>
) are now written as unicode characters, a recommended practice.test.html
) was added under Resources.