Unquote response location in assertRedirect #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Flask url encodes query params which makes testing the location of a redirect slightly awkward. This fixes the problem by unquoting the url making for simpler assertions. eg. `self.assertRedirects(res, '/login?next=/account')`
|
I guess this won't be merged as it is not Python 3 compatible (see failed CI build)? |
|
The current state isn't python 3 compatible, but I also believe this should be kept as is by design. The query string parameter should be url encoded and the assertion should reflect that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Flask url encodes query params which makes testing the location of a redirect slightly awkward.
eg.
self.assertRedirects(res, '/login?next=/somewhere/')currently fails with'http://localhost/?next=%2Fsomewhere%2F' != 'http://localhost/?next=/somewhere/'This fixes the problem by unquoting the response location before asserting equality.