Use gid_t and uid_t in passwd.h
#995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`group.gr_gid` was the wrong type (`int32_t` when `gid_t` is `uint32_t`). Just replaced all the types for uids and gids with the appropriate `uid_t` or `gid_t`, which incidentally fixes that inconsistency.
jart
reviewed
Dec 9, 2023
There was a problem hiding this comment.
The integration tests will most likely fail on the $(THIRD_PARTY_MUSL_A_HDRS:%=o/$(MODE)/%.ok) check due to the header not including libc/call/weirdtypes.h. I'd recommend only changing gr_gid to be uint32_t. I like it that way in the mono repo. Less include complexity.
jart
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group.gr_gidwas the wrong type (int32_twhengid_tisuint32_t). Just replaced all the types for uids and gids with the appropriateuid_torgid_t, which incidentally fixes that inconsistency.