Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cover all invalid refcounts #976

Merged
merged 1 commit into from
Dec 3, 2023
Merged

cover all invalid refcounts #976

merged 1 commit into from
Dec 3, 2023

Conversation

mrdomino
Copy link
Collaborator

@mrdomino mrdomino commented Dec 1, 2023 •
edited
Loading

No description provided.

@mrdomino mrdomino changed the title unassert negative refcounts npassert negative refcounts Dec 1, 2023
@mrdomino mrdomino changed the title npassert negative refcounts cover all invalid refcounts Dec 1, 2023
@mrdomino
refs is atomic_size_t
5e685a9 
The unassert covers all invalid values rather than a third of them.
jart
jart approved these changes Dec 3, 2023
View reviewed changes
Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jart jart merged commit 8dd3480 into jart:master Dec 3, 2023
5 checks passed
@mrdomino mrdomino deleted the refcheck branch December 3, 2023 04:39
G4Vi pushed a commit to G4Vi/cosmopolitan that referenced this pull request Jan 19, 2024
@mrdomino @G4Vi
refs is atomic_size_t (jart#976)
a3bb718 
The unassert covers all invalid values rather than a third of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jart jart jart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrdomino @jart