Fix Clang/LLD woes! #343
Closed
Fix Clang/LLD woes! #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several changes to get Clang and LLD working again: - LLD will always place non-allocated sections at LMA(0x0). Flagged the .zip section as 'a' to fix this. - LLD interprets DEFINED(x) in a subtly-different way, where any symbol declaration counts as defining. Changed several default-value definitions that used DEFINED to instead use PROVIDE_HIDDEN. - Due to the same LLD/DEFINED behavior, EfiMain was always getting linked in. Updated to use a separate flagging variable (USE_EFI). - Clang needed a few new flags to match GCC frame/stack behavior.
|
Thank you but after giving it some thought I've decided that I want to delete the commented Clang/LLD code for the time being. Even when it was working it caused a lot of issues for Linux users. |
jart
added a commit
that referenced
this pull request
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes to get Clang and LLD working again (GH-180):
section as 'a' to fix this.
declaration counts as defining. Changed several default-value
definitions that used DEFINED to instead use PROVIDE_HIDDEN.
linked in. Updated to use a separate flagging variable (USE_EFI).