Fix occasional crash in test/libc/intrin/mmap_test #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test would sometimes crash due to the EZBENCH2() macro occasionally running the first benchmark (BenchMmapPrivate()) less times than it does the second benchmark (BenchUnmap()) - this would then lead to a crash in BenchUnmap() because BenchUnmap() expects that BenchMmapPrivate() has to previously have been called at least as many times as it has itself such that a region of memory has been mapped, for BenchUnmap() to then unmap. This commit fixes this by utilizing the newer BENCHMARK() macro (instead of the EZBENCH2() macro) which runs the benchmark using an count of runs specified directly by the benchmark itself, which allows us to make sure that the two benchmark functions get ran the exact same amount of times.
GabrielRavier
force-pushed
the
fix/occasional-crash-in-test-libc-intrin-mmap_test
branch
from
80cb47c to
7272124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test would sometimes crash due to the EZBENCH2() macro occasionally
running the first benchmark (BenchMmapPrivate()) less times than it does
the second benchmark (BenchUnmap()) - this would then lead to a crash in
BenchUnmap() because BenchUnmap() expects that BenchMmapPrivate() has to
previously have been called at least as many times as it has itself such
that a region of memory has been mapped, for BenchUnmap() to then unmap.
This commit fixes this by utilizing the newer BENCHMARK() macro (instead
of the EZBENCH2() macro) which runs the benchmark using an count of runs
specified directly by the benchmark itself, which allows us to make sure
that the two benchmark functions get ran the exact same amount of times.