Fix rare corner case in ntspawn.c #1284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be cases when libc/proc/describefds.c calls calloc(handlecount, ..) with handlecount = 0
to initialize what will later become opt_lpExplicitHandleList. But calloc(0, ..) does not always return null
according to https://learn.microsoft.com/ka-ge/cpp/c-runtime-library/reference/calloc?view=msvc-140
If the chosen conditional is a->opt_lpExplicitHandleList then UpdateProcThreadAttribute is called and
produces a Windows error. The modification avoids this problem.