[redbean] Add UuidV4 method #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdomino
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Much of this is as discussed in Discord, as well as a couple minor nits.
Looks good overall.
I'm not totally opposed to checking in the unrolled loop, I just want to push back once more, particularly in light of needing to use random() (which might change the performance margins already.)
mrdomino
reviewed
Apr 11, 2024
This comment was marked as outdated.
This comment was marked as outdated.
mrdomino
reviewed
Apr 12, 2024
jart
pushed a commit
that referenced
this pull request
Jul 1, 2024
To Complete #1140 add UUID version 7 to Redbean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the UuidV4 Lua method.