Re-enable/fix non-argv[0] exe name tests #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should always pass no matter what and if they don't it's a bug somewhere. Cases where they fail: - assimilated binary on OpenBSD or x86_64 XNU (no `KERN_PROC_PATHNAME`) - bad loader that did not implement `RealPath` on Free/Net BSD
Properly tests the behavior on Metal now, which is to always return `APE_COM_NAME`. Ensures that the path of the test itself as returned by `GetProgramExecutableName` is executable.
GetProgramExecutableName does not work right on assimilated OpenBSD or non-silicon XNU binaries. If we are on one of those platforms, look for ape magic in ourselves and quit if none is found. If `argv[0]` is not reliable for the test invocation itself (e.g. because the test is run out of `PATH`), the test assert-fails.
jart
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests should now pass in all cases and if they don't it's a bug.
One buggy case is if they're run against the short-lived loader that used a stubbed
RealPathon FreeBSD and NetBSD; if they fail on those platforms it's likely for that reason.Still TODO, preferably in a future PR:
GetProgramExecutableNamereliable for assimilated XNU binaries; it seems like this might be doable with whatdyld::getExecutablePath(and therefore_NSGetExecutablePath) uses.argv[0]tests on all platforms, probably by using the to-be-writtencosmo_execve.There is probably nothing for assimilated OpenBSD binaries, so the check introduced will probably never completely go away.