Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isutf8: implement RFC 3629 #1045

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

isutf8: implement RFC 3629 #1045

wants to merge 1 commit into from

Conversation

wingdeans
Copy link

reject surrogate pairs (U+D800 to U+DFFF)
reject greater than U+10FFFF

From RFC 3629:

The definition of UTF-8 prohibits encoding character numbers between
U+D800 and U+DFFF, which are reserved for use with the UTF-16
encoding form (as surrogate pairs) and do not directly represent
characters.

12. Changes from RFC 2279

  • Restricted the range of characters to 0000-10FFFF (the UTF-16 accessible range).

reject surrogate pairs (U+D800 to U+DFFF)
reject greater than U+10FFFF
Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. OOC have you seen tool/net/ljson.c? We put a little bit more effort into that one, due to the comprehensive test suites we have for it under test/tool/net/.

I just need one process hurdle from you first before I can merge. Can
you please send an email to [email protected] saying "I intend to assign
you the copyright to the changes I contribute to Cosmopolitan"? It only
applies to the changes you choose to contribute. It only needs to happen
once. If your employer owns everything you do, then you'll need to clear
it with them first. Please do that if you need to and get it on the
record. Please link to this PR inside your email. Thanks!

@G4Vi
Copy link
Collaborator

G4Vi commented Apr 11, 2024

@wingdeans I'm interested in merging this. Can you send the copyright assignment to Justine and report back when or if you've done so? If you're unable or not interested feel free to close this as we cannot add your code otherwise.

@jart jart force-pushed the master branch 2 times, most recently from faa6285 to 2c4b887 Compare July 25, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants