Fix loader usage, shave off a few bytes #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-f was removed in 1.5. As there is now only one flag, a couple more bytes can be shaved off as well.
Shaves off a few bytes, paying for the cost of `RealPath` and then some on x86_64 and offsetting some of the cost to aarch64.
Removes `-h` and flags from usage. Keeps flag-parsing logic the same, i.e. still accepts `-h` / `--help`. Only difference is what fd and rc the usage uses. Still over 1k north of 8192.
|
Calling it; this is ready to go if we want it. If I understand correctly it's not going to make a difference with everything being 4k-aligned, but I believe this is a (slight) improvement. |
jart
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-ffunctionality was removed in ape loader version 1.5.Shaves some bytes off here and there; functionality remains the same modulo usage string, but each change reduces binary size slightly.