Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable argv[0] tests on non-XnuSilicon #1015

Merged
merged 2 commits into from
Dec 25, 2023
Merged

Disable argv[0] tests on non-XnuSilicon #1015

merged 2 commits into from
Dec 25, 2023

Conversation

mrdomino
Copy link
Collaborator

No description provided.

@mrdomino
Copy link
Collaborator Author

mrdomino commented Dec 15, 2023 •
edited
Loading

This can be merged as-is to make the tests pass after the new loader has been minted, or sys_execve can be modified and this change dropped.

Context: #1014.

@mrdomino mrdomino changed the title Blanket-disable argv[0] tests on linux (#1014) Blanket-disable argv[0] tests on linux Dec 15, 2023
@mrdomino mrdomino mentioned this pull request Dec 15, 2023
Closed
@mrdomino mrdomino changed the title Blanket-disable argv[0] tests on linux Disable argv[0] tests on non-XnuSilicon Dec 17, 2023
@mrdomino
Copy link
Collaborator Author

The correct feature test is now spelled out in a comment, and the de facto !IsXnuSilicon() more closely matches reality.

@pkulchenko pkulchenko self-requested a review December 24, 2023 20:18
pkulchenko
pkulchenko approved these changes Dec 24, 2023
View reviewed changes
Copy link
Collaborator

@pkulchenko pkulchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrdomino mrdomino marked this pull request as draft December 25, 2023 00:40
@mrdomino mrdomino marked this pull request as ready for review December 25, 2023 00:41
@mrdomino
Copy link
Collaborator Author

Waffled on merging this, but I think I will push it to reduce noise on BSD tests, and just rewrite it in terms of something like the hypothetical cosmo_execve soon.

@mrdomino mrdomino merged commit 4c6f928 into jart:master Dec 25, 2023
5 checks passed
@mrdomino mrdomino deleted the linux-execve branch December 25, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkulchenko pkulchenko pkulchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrdomino @pkulchenko