Skip to content

Commit

Permalink
[redbean] Add details to OnError Hook (#1324)
Browse files Browse the repository at this point in the history
The details of the error was missing, this PR add details to the OnError
hook so we can now get why the error occurs
  • Loading branch information
solisoft authored Nov 20, 2024
1 parent 1312f60 commit ad0a7c6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tool/net/help.txt
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ HOOKS
*). See functions like Route which asks redbean to do its default
thing from the handler.

OnError(status:int, message:string)
OnError(status:int, message:string, details:string)
If this function is defined and if any errors occurs in
OnHttpRequest() then this method will be called instead of displaying
the default error page. Useful if you need to display the error page
Expand Down
3 changes: 2 additions & 1 deletion tool/net/redbean.c
Original file line number Diff line number Diff line change
Expand Up @@ -2620,7 +2620,8 @@ static char *ServeErrorImpl(unsigned code, const char *reason,
lua_getglobal(L, "OnError");
lua_pushinteger(L, code);
lua_pushstring(L, reason);
if (LuaCallWithTrace(L, 2, 0, NULL) == LUA_OK) {
lua_pushstring(L, details);
if (LuaCallWithTrace(L, 3, 0, NULL) == LUA_OK) {
return CommitOutput(GetLuaResponse());
} else {
return ServeErrorImplDefault(code, reason, details);
Expand Down

0 comments on commit ad0a7c6

Please sign in to comment.