bugfix wrap function: nested wrap call on other cache instance - results in deadlock #967
+102
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lts in deadlock - wrap function hangs indefinitely.
…ered by refreshThreshold (jaredwray#965) Co-authored-by: Jared Wray <[email protected]>
|
@yaronyam - can you resolve the conflicts from the previous merge so I can review? |
…lts in deadlock - wrap function hangs indefinitely.
…o bugfix/nested_wrap_deadlock # Conflicts: # packages/cache-manager/test/wrap.test.ts
|
sure. updated |
|
@yaronyam - thanks for your work on this. I make this an enhancement as I would like to provide the |
|
cool 👍 |
Let me know when you get those changes in and I will get this merged. |
… random string. expose Cache#cacheId() method to return cacheId.
|
updated with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrapfunction: nestedwrapcall on other cache instance with same key - results in deadlock, wherewrapfunction call hangs indefinitely