Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: use envinfo for getting versions in issue reports #820

Merged
merged 1 commit into from
Aug 23, 2020

Conversation

agilgur5
Copy link
Collaborator

Description

Tags

I actually suggested using this myself in #167, which was one of my first issues here

- replace the version table with a copy+paste this `envinfo` command,
  copy back the output
  - saw `nyc` using this about a year ago and thought it was super
    useful; finally got around to adding it here
    - https://github.com/istanbuljs/nyc/blame/00c3b3440a5b2ffe11b9c19ae4e08ad2f5b70e33/.github/ISSUE_TEMPLATE.md#L20-L23
    - exact language was modified and updated from
      https://github.com/styled-components/styled-components/blame/53bc31f/.github/ISSUE_TEMPLATE.md#L34
      as TSDX does not have its own envinfo preset
      - perhaps worth creating one?
    - code snippet inspired from
      https://github.com/facebook/jest/blame/4d32070/.github/ISSUE_TEMPLATE/bug.md#L35

- this should make reporting versions zero-effort and thereby
  significantly decrease non-reporting by making the hard thing easy
  - have had a few places that didn't report and version was *very*
    relevant to the issue
  - also have had several that reported "latest" or used carets, which
    lacks posterity or is confusing
@vercel
Copy link

vercel bot commented Aug 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/bx7p9ouwj
✅ Preview: https://tsdx-git-fork-agilgur5-envinfo-for-issues.formium.vercel.app

Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, iterated a few times already

@agilgur5 agilgur5 merged commit 349f299 into jaredpalmer:master Aug 23, 2020
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
…r#820)

- replace the version table with a copy+paste this `envinfo` command,
  copy back the output
  - saw `nyc` using this about a year ago and thought it was super
    useful; finally got around to adding it here
    - https://github.com/istanbuljs/nyc/blame/00c3b3440a5b2ffe11b9c19ae4e08ad2f5b70e33/.github/ISSUE_TEMPLATE.md#L20-L23
    - exact language was modified and updated from
      https://github.com/styled-components/styled-components/blame/53bc31f/.github/ISSUE_TEMPLATE.md#L34
      as TSDX does not have its own envinfo preset
      - perhaps worth creating one?
    - code snippet inspired from
      https://github.com/facebook/jest/blame/4d32070/.github/ISSUE_TEMPLATE/bug.md#L35

- this should make reporting versions zero-effort and thereby
  significantly decrease non-reporting by making the hard thing easy
  - have had a few places that didn't report and version was *very*
    relevant to the issue
  - also have had several that reported "latest" or used carets, which
    lacks posterity or is confusing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant