-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): templates should not have baseUrl or paths set #707
Merged
agilgur5
merged 1 commit into
jaredpalmer:master
from
agilgur5:fix-remove-template-baseUrl-paths
May 3, 2020
Merged
(fix): templates should not have baseUrl or paths set #707
agilgur5
merged 1 commit into
jaredpalmer:master
from
agilgur5:fix-remove-template-baseUrl-paths
May 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- there are many issues about TS path aliases not fully "working", so they should be removed from the templates until they are completely "working" - instead of shipping templates with a partially "broken" and confusing configuration enabled - especially confusing to users because editors will auto-complete with the absolute path instead of the relative path - and the fact that these paths are unresolved at build or test time means that it's not understood that this is "broken" until later in the process - this is a *very* common misconception with TS users that `paths` rewrites/transforms imports during compilation, but it actually does not change any absolute paths to relative, it leaves them as is - it just resolves type information to help on platforms that import differently - basically, it's somewhat of a legacy option, but folks think it's used for aliases and does transforms - and folks seem to want it to work that way too - it actually does the reverse, it supports the usage of aliases/import rewrites elsewhere - unfortunately this misconception made its way into the very first template, causing lots of confusion and issues reported since - so `paths` isn't "broken" per se, it just doesn't do what people think it does (including template authors) - well it *is* broken for standard TSDX usage out-of-the-box - since TSDX doesn't output for platforms where it makes sense out-of-the-box - as a result, for aliases to be fully supported by TSDX, we'd have to add some sort of transformation(s) for build, test, and lint - until then this shouldn't be in the templates - but don't give an error on it because there are methods/"workarounds" to support aliasing/import rewrites using the configuration in `paths` - and if one is using import rewrites, `paths` is necessary for TS to not give errors - also removes an inconsistency in the Storybook template that used "@/*" as an alias, even though the other templates didn't have that - while this is a supported alias by some libraries in the community, - oversight in code review when Storybook templates were added and caused some confusion for users - also removes these options from all test fixtures
agilgur5
added
the
topic: TS Paths Aliases
Related to using aliases with TypeScript paths
label
May 3, 2020
agilgur5
commented
May 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Mostly just the same 4 lines removed everywhere
This was
linked to
issues
May 3, 2020
velut
added a commit
to velut/short-time-ago
that referenced
this pull request
Aug 29, 2020
velut
added a commit
to velut/query-registry
that referenced
this pull request
Aug 29, 2020
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
- there are many issues about TS path aliases not fully "working", so they should be removed from the templates until they are completely "working" - instead of shipping templates with a partially "broken" and confusing configuration enabled - especially confusing to users because editors will auto-complete with the absolute path instead of the relative path - and the fact that these paths are unresolved at build or test time means that it's not understood that this is "broken" until later in the process - this is a *very* common misconception with TS users that `paths` rewrites/transforms imports during compilation, but it actually does not change any absolute paths to relative, it leaves them as is - it just resolves type information to help on platforms that import differently - basically, it's somewhat of a legacy option, but folks think it's used for aliases and does transforms - and folks seem to want it to work that way too - it actually does the reverse, it supports the usage of aliases/import rewrites elsewhere - unfortunately this misconception made its way into the very first template, causing lots of confusion and issues reported since - so `paths` isn't "broken" per se, it just doesn't do what people think it does (including template authors) - well it *is* broken for standard TSDX usage out-of-the-box - since TSDX doesn't output for platforms where it makes sense out-of-the-box - as a result, for aliases to be fully supported by TSDX, we'd have to add some sort of transformation(s) for build, test, and lint - until then this shouldn't be in the templates - but don't give an error on it because there are methods/"workarounds" to support aliasing/import rewrites using the configuration in `paths` - and if one is using import rewrites, `paths` is necessary for TS to not give errors - also removes an inconsistency in the Storybook template that used "@/*" as an alias, even though the other templates didn't have that - while this is a supported alias by some libraries in the community, - oversight in code review when Storybook templates were added and caused some confusion for users - also removes these options from all test fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: bug
Something isn't working
topic: TS Paths Aliases
Related to using aliases with TypeScript paths
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are many issues about TS path aliases not fully "working", so
they should be removed from the templates until they are completely
"working"
confusing configuration enabled
with the absolute path instead of the relative path
means that it's not understood that this is "broken" until later in
the process
this is a very common misconception with TS users that
paths
rewrites/transforms imports during compilation, but it actually does
not change any absolute paths to relative, it leaves them as is
differently
used for aliases and does transforms
aliases/import rewrites elsewhere
template, causing lots of confusion and issues reported since
so
paths
isn't "broken" per se, it just doesn't do what peoplethink it does (including template authors)
out-of-the-box
as a result, for aliases to be fully supported by TSDX, we'd have to
add some sort of transformation(s) for build, test, and lint
methods/"workarounds" to support aliasing/import rewrites using
the configuration in
paths
paths
is necessary forTS to not give errors
also removes an inconsistency in the Storybook template that used
"@/*" as an alias, even though the other templates didn't have that
while this is a supported alias by some libraries in the community,
oversight in code review when Storybook templates were added and
caused some confusion for users
also removes these options from all test fixtures
Long time coming for this one, these have been in the codebase since the very first template was added in 9010ecb and have caused much confusion since then.
Fixes the root cause of #91, #699, #516, #139, #133, etc, but doesn't add an import/rewrite mechanism, which has been requested in some of those issues. Does fix confusion / bugs due to the faulty templates. Specifically:
Full support for aliases, i.e. an import rewrite/transform mechanism, will be added eventually, keep an eye on #91 for that.