BoardInitGmac: Fix byte-swapped MAC address #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMAC[01]_MAC_ADDRESS0_{LOW,HIGH} were written in MSB,
but they should be in LSB.
See also the fix for NetBSD eqos(4) driver:
NetBSD/src@8c816b8
Tested for Quartz64. For other boards, compile-test only.
|
Thanks for the patch! When generating a random address, we could set the locally administered bit and clear the multicast bit for both bytes 0 and 3, to maintain compatibility with kernels that expected the byte-swapped address. What do you think? |
|
On 2023/10/24 8:07, Jared McNeill wrote:
Thanks for the patch! When generating a random address, we could set the locally administered bit and clear the multicast bit for both bytes 0 and 3, to maintain compatibility with kernels that expected the byte-swapped address. What do you think?
Sounds nice! No objection from me (and msaitoh @ netbsd).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GMAC[01]MAC_ADDRESS0{LOW,HIGH} were written in MSB, but they should be in LSB.
See also the fix for NetBSD eqos(4) driver:
NetBSD/src@8c816b8
Tested for Quartz64. For other boards, compile-test only.