Fixed adding a gateway with a dynamic address to Firewall Rules. Added tag field to Firewall Rules #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTrushkovsky
changed the title
|
This definitely works, I'll have this in the next patch. Thank you! As a workaround for now, the Gateway model does actually take into account dynamic gateways and they can be used in this field, but only after they've been saved to the config. For some reason, pfSense does not store the initial dynamic gateways in the config by default and only will if you edit the gateway and save it in the UI (or create the dynamic gateway via the API). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understood, in the firewall rules in the api, you can select only a gateway with a static ip address, but for firewall rules you can also connect a gateway with a dynamic address (for example, OpenVPN).
The tag field has also been added.