Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package is no longer architecture specific #393

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

elacy
Copy link
Contributor

@elacy elacy commented Sep 3, 2023

This is to resolve this issue: #239
Netgate devices run on arm, and by default FreeBSD will make the package specific to whatever architecture you build it on. By adding NO_ARCH=yes the package will not be architecture specific and so it won't require that you force install. It also allows you to do automatic updates.

You might have thought that Netgate would get around to making their own api for pfsense+ like you mentioned in this issue, sadly not.

@jaredhendrickson13
Copy link
Owner

Looks good to me, thanks!

I will note that not supporting amd64 and aarch64 installations is more of an intentional decision than a technical limitation. Without purchasing Netgate hardware, I only have access to publicly available (amd64) builds of pfSense, this includes the amd64 builds of pfSense Plus. Even though it's very unlikely, if a conflict did arise in the future I would be unable to effectively troubleshoot or write tests for potential issues specific to different architectures. However, this change will allow this subset of users to use the package without force installing; which will retain certain features for users installing the package on non-supported architectures.

Thanks again!

@jaredhendrickson13 jaredhendrickson13 merged commit 7b56876 into jaredhendrickson13:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants