v1.6.0 Fixes & Features #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these pfsense versions will no longer be supported going forward
the get_existing_tokens() function was receiving a fatal error if no api tokens existed when calling. the authenticate_token() function was failing to evaluate the username from index_users() because php 8 does not implicitly compare items do array keys using in_array() anymore
removes the shadowed is_alias() function from APITools.inc. pfSense has a built in function that does the same thing so it is redundant. this change fixes crashes on /api/v1/firewall/nat/one_to_one on PHP 8.1 and possibly elsewhere.
adds the init_config() method to API models to simplify initializing configuration arrays. this fixes many issues related to PHP 8.1
removes the old api function sort_firewall_rules and uses the built in pfSense function filter_rules_sort instead. this also fixes php 8 compatibility issues.
fixes php 8 issues
changes __compare_schedules() private method to compare_schedules() public method in APIFirewallScheduleDelete to fix error on php 8
changes __compare_schedules() private method to compare_schedules() public method in APIFirewallScheduleCreate to fix error on php 8
changes __compare_schedules() private method to compare_schedules() public method in APIFirewallScheduleUpdate to fix error on php 8
the changes with php8 will break backwards compatibility with these releases
jaredhendrickson13
added
the
work in progress
This was
linked to
issues
Jun 21, 2023
This was
linked to
issues
Jul 1, 2023
This helps cut down on the amount of test printed to the console during E2E tests
jaredhendrickson13
removed
the
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
/etc/rc.restart_weguiis no longer required after package installation on these releases.Refactors
onlinefield on /api/v1/status/dhcpd/lease no longer returns a boolean value, now returns a string indicating the exact online status of the lease. (23.01 - DHCP Table shows all leases online = false #340)Fixes
monitorfield now gets unset whenmonitor_disableis set totrueon /api/v1/routing/gateway.CI & Testing
Removes