API version compare returns always "update_available" false

[av-commits]

Describe the bug
intval in function below with version string starting with v e.g. v1.6.1 always return 0 --> 0 < 0 --> false

pfsense-api/pfSense-pkg-API/files/etc/inc/api/models/APISystemAPIVersionRead.inc

Line 68 in 1b19911

public static function is_update_available() {

I would recommend to use php version_compare()
return version_compare(self::get_api_version(), self::get_latest_api_version()) == -1;

that work in my tests and also handles thing like 1.12.1 lower version then 2.0.1

To Reproduce
Steps to reproduce the behavior:

1. Call /api/v1/system/api/version on old api version system

Expected behavior
Return true if new API version is available

Screenshots or Response
n/a

pfSense Version & Package Version:

• pfSense Version: pfSense 2.7.0
• Package Version v1.6.1 / v1.6.2

Affected Endpoints:

• URL: /api/v1/system/api/version

Additional context

[jaredhendrickson13]

Sounds like a great option. I'll include this in the next patch.

Thanks!