Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to hide disabled users from All Users #9

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

schrauger
Copy link

I added a bunch of code that adds the ability to hide disabled users from the All Users listing.

  • Settings page added to let the admin either show disabled users intermixed (default, current functionality) or to remove them from the listing.
  • Added a link to the Disabled column to show or hide disabled users, depending on what the plugin setting preference was set to.
  • Added a submenu link to display only disabled users.

Since there was a fair amount of new stuff, feel free to pick and choose (or reject outright) things from the pull request. I just thought I'd share my additions.

Note: I didn't make sure any internationalization or language translations were added or adjusted. That will probably need to be tweaked if you want to have other languages for the new features.

schrauger and others added 4 commits March 8, 2016 13:08
Describes new functionality with settings page and hiding users from All Users.
Updates changelog with version updates.
@jaredatch
Copy link
Owner

Nice, I'll take a look at this soon as I get some time. Then provide feedback if needed and work towards merge. I might go ahead and look at knocking out a few of the other issues as well in the same update.

Any reason you jumped the version to 1.2.x instead of 1.1?

@schrauger
Copy link
Author

I think I incremented the number when I started working on it, then incremented it again near the end, forgetting I had already incremented the version number.

@schrauger
Copy link
Author

Also, I've already found one bug, or at least a usability issue. The network admin "Users" section doesn't show the Disabled column nor does it show the submenu I added to only show disabled users. So if the preference 'hide disabled users' is set, there is no way to view those users in the network admin area, only in the subsites.

I'll tweak it tomorrow to work with network sites.

@jaredatch
Copy link
Owner

No worries, I was just wondering. Looks solid, like I said I'll look it over in more depth soon as I get the chance 👍

@jaredatch
Copy link
Owner

@schrauger did you ever have a chance look at the network admin issue? If not no worries, just wanted to check in :)

@schrauger
Copy link
Author

@jaredatch I forgot about this until you mentioned it.

I went ahead and fixed the bugs. Now, network admin pages show the plugin settings, network users show the disabled column and extra disabled-only page links, and everything works as far as I can see.

@schrauger
Copy link
Author

Just wondering if you ever got a chance to look at the code I wrote. It has been working for our company for almost a year now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants