Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try_println instead of println for safe pipe handling #3

Merged
merged 3 commits into from
Oct 13, 2018
Merged

Use try_println instead of println for safe pipe handling #3

merged 3 commits into from
Oct 13, 2018

Conversation

jarcane
Copy link
Owner

@jarcane jarcane commented Oct 10, 2018

This solves the crash in issue #2.

@jarcane
Copy link
Owner Author

jarcane commented Oct 10, 2018

On further testing it appears this reintroduces our performance issue from #1.

@jarcane
Improve performance by avoiding string allocation
de057d9
@jarcane
Use writeln! instead
042b9f1 
This avoids performance regression introduced by try_print!
@jarcane jarcane merged commit a2579b0 into master Oct 13, 2018
@jarcane
Copy link
Owner Author

jarcane commented Oct 13, 2018

Switched to a hand implementation with writeln! but it seems to work well and avoids the crash bug mentioned in #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jarcane