Proposed fix for Issue #17 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulate_left_margin(). This prevents an infinite recursion problem calling ourselves if a user subclasses the Line class.
|
You're right. This code is from my fairly early days in Python and coming from C++, I wanted so badly not to have to write the class name in a super call. Thanks to Python 3, eventually this won't be necessary, but for now, it's exactly the right thing to do. |
|
3.4.4 is rolling out now with this fix. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "Line" instead of "self.class" in call to super() inside calculate_left_margin(). This prevents an infinite recursion problem calling ourselves if a user subclasses the Line class.
Proposed fix for Issue #17.