Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support React Refresh #1069

Draft
wants to merge 73 commits into
base: master
Choose a base branch
from
Draft

[WIP] Support React Refresh #1069

wants to merge 73 commits into from

Commits on Jun 1, 2022

  1. Add testEmissions module with ReactRefresh JS test

    @japgolly
    japgolly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    419509d View commit details
    Browse the repository at this point in the history

  2. Add EmissionTest

    @japgolly
    japgolly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    67f0713 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into topic/refreshReact

    @japgolly
    japgolly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    7d5f589 View commit details
    Browse the repository at this point in the history

  4. Update emissions for SJS 1.10

    @japgolly
    japgolly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    f0e130f View commit details
    Browse the repository at this point in the history

  5. Separate emission expectations by Scala version

    @japgolly
    japgolly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9f484dc View commit details
    Browse the repository at this point in the history

  6. Emissions output: replace unicode "_", add trailing line

    @japgolly
    japgolly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    3d057f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Tweak EmissionTest conditions to showResult

    @japgolly
    japgolly committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    5796d2e View commit details
    Browse the repository at this point in the history

  2. Finally get working macros in place for a render hook method

    @japgolly
    japgolly committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    1717979 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Remove useless line

    @japgolly
    japgolly committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    89ee1f2 View commit details
    Browse the repository at this point in the history

  2. Checkpoint: UseState on Scala 2

    @japgolly
    japgolly committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    8197dd3 View commit details
    Browse the repository at this point in the history

  3. HookDefn propsType not needed

    @japgolly
    japgolly committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    d3b8a09 View commit details
    Browse the repository at this point in the history

  4. Handle useStateBy and withPropsChildren

    @japgolly
    japgolly committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    39ce3dc View commit details
    Browse the repository at this point in the history

  5. Fix formatting

    @japgolly
    japgolly committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    bee7150 View commit details
    Browse the repository at this point in the history

  6. Add TODO

    @japgolly
    japgolly committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    ff104a4 View commit details
    Browse the repository at this point in the history

  7. Remove NoHooksWithChildren for now

    @japgolly
    japgolly committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    008744e View commit details
    Browse the repository at this point in the history

  8. Fix and harden ReactRefreshTest

    @japgolly
    japgolly committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    d2e6f64 View commit details
    Browse the repository at this point in the history

  9. Rewrite useStateWithReuse{,By}

    @japgolly
    japgolly committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    656a963 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Create AbstractHookMacros

    @japgolly
    japgolly committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    cfb090c View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Add tcc sbt alias

    @japgolly
    japgolly committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    2005e88 View commit details
    Browse the repository at this point in the history

  2. Prepare AbstractHookMacros for Scala 3

    @japgolly
    japgolly committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    9967f39 View commit details
    Browse the repository at this point in the history

  3. Let's try an external HookRewriterCtx

    @japgolly
    japgolly committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    1dda343 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Refactor HookRewriter so that ValDef creation is atomic

    @japgolly
    japgolly committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    b9ccc8b View commit details
    Browse the repository at this point in the history

  2. Rename tec alias

    @japgolly
    japgolly committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    d763377 View commit details
    Browse the repository at this point in the history

  3. Further prep for Scala 3 support

    @japgolly
    japgolly committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c69eaf1 View commit details
    Browse the repository at this point in the history

  4. Scala 3 rewriting acting like its working

    @japgolly
    japgolly committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    e3c8da8 View commit details
    Browse the repository at this point in the history

  5. Silence macrotasks warnings in downstream-tests

    @japgolly
    japgolly committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    3bc3af9 View commit details
    Browse the repository at this point in the history

  6. Make SNAPSHOT versions stable

    @japgolly
    japgolly committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    9425f16 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Give up trying to preserve bincompat

    @japgolly
    japgolly committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    fd38f4b View commit details
    Browse the repository at this point in the history

  2. Revert "Give up trying to preserve bincompat" 

    This reverts commit fd38f4b.
    @japgolly
    japgolly committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    11f0cf5 View commit details
    Browse the repository at this point in the history

  3. Recover bincompat, turns out there was a node version issue

    @japgolly
    japgolly committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    02b1f18 View commit details
    Browse the repository at this point in the history

  4. Generate test emissions with less SJS safety

    @japgolly
    japgolly committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    76790d5 View commit details
    Browse the repository at this point in the history

  5. Make emission testing output more useful for debugging

    @japgolly
    japgolly committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    48f92cf View commit details
    Browse the repository at this point in the history

  6. Add renderDebug

    @japgolly
    japgolly committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    84d6666 View commit details
    Browse the repository at this point in the history

  7. Turn rewrite failures into compiler warnings

    @japgolly
    japgolly committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    386f6a7 View commit details
    Browse the repository at this point in the history

  8. Support function refs in rewrite args

    @japgolly
    japgolly committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    13b9041 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Validate react-refresh version

    @japgolly
    japgolly committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    f0f87f9 View commit details
    Browse the repository at this point in the history

  2. Upgrade to react-refresh 0.13.0

    @japgolly
    japgolly committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    3a75383 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Support custom* hook methods

    @japgolly
    japgolly committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    065ddb3 View commit details
    Browse the repository at this point in the history

  2. Properly handle intermediary hooks with Unit results

    @japgolly
    japgolly committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    2f1851c View commit details
    Browse the repository at this point in the history

  3. Refactor and improve readability of new hook macro code

    @japgolly
    japgolly committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    b28aac6 View commit details
    Browse the repository at this point in the history

  4. Improve ReactRefreshTest 

    * more informative per-test output
* easier to support tests with RR isn't expected
    @japgolly
    japgolly committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    725a7fd View commit details
    Browse the repository at this point in the history

  5. Add emission tests for custom hooks

    @japgolly
    japgolly committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    1128fc4 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Upgrade react-refresh to 0.14.0 (identical to 0.13.0 anyway)

    @japgolly
    japgolly committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    7275c97 View commit details
    Browse the repository at this point in the history

  2. Oh no, custom hooks need rewriting too

    @japgolly
    japgolly committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    1a13dfe View commit details
    Browse the repository at this point in the history

  3. Gonna have to add renderRR and leave render alone 

    A few reasons:

* https://github.com/lampepfl/dotty/issues/15435 requires an
  extension method

* it's actually better to make it opt-in for now until it's fully
  stable, seeing as it's turning out to be more complex than expected

* similarly, having the ability to use the existing, stable, render
  method would be advantageous if an unexpected error occurs in renderRR
    @japgolly
    japgolly committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    931a8d3 View commit details
    Browse the repository at this point in the history

  4. Test hook components with .render and with .renderRR

    @japgolly
    japgolly committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    cbdd990 View commit details
    Browse the repository at this point in the history

  5. Reorder methods in HookMacros

    @japgolly
    japgolly committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    19a50aa View commit details
    Browse the repository at this point in the history

  6. Refactor: rename secondary render macro methods

    @japgolly
    japgolly committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    073ee30 View commit details
    Browse the repository at this point in the history

  7. Fix rewriting of custom hooks with local vals in Scala 3 

    This is the fix/workaround for lampepfl/dotty-feature-requests#307
    @japgolly
    japgolly committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    faac76e View commit details
    Browse the repository at this point in the history

  8. Make Hook{Defn,Step} static

    @japgolly
    japgolly committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    6f16bcb View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. Support RR on the hooks primary API

    @japgolly
    japgolly committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    729ef6d View commit details
    Browse the repository at this point in the history

  2. Refactor for readability

    @japgolly
    japgolly committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    70cde24 View commit details
    Browse the repository at this point in the history

  3. Support and test, all variations of hook component creation with RR

    @japgolly
    japgolly committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d0e4ea6 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Support rewriting of local* and unchecked* hooks

    @japgolly
    japgolly committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    c07533a View commit details
    Browse the repository at this point in the history

  2. Tiny tweak - too tired to actually describe

    @japgolly
    japgolly committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    de5e001 View commit details
    Browse the repository at this point in the history

  3. Inline HookCtx stuff

    @japgolly
    japgolly committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    f2c63de View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Got useCallback working

    @japgolly
    japgolly committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    63a2045 View commit details
    Browse the repository at this point in the history

  2. Rename last context object to render_ctx

    @japgolly
    japgolly committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    8298460 View commit details
    Browse the repository at this point in the history

  3. Support useCallbackWithDeps*

    @japgolly
    japgolly committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    55723b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. useMemo* done

    @japgolly
    japgolly committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    6d66364 View commit details
    Browse the repository at this point in the history

  2. use{Context,DebugValue,Reducer} done

    @japgolly
    japgolly committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    142f6e1 View commit details
    Browse the repository at this point in the history

  3. Avoid shadowing in Scala 2

    @japgolly
    japgolly committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    2fb130a View commit details
    Browse the repository at this point in the history

  4. Consolidate some RR tests; test time is starting to get annoying

    @japgolly
    japgolly committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    e868482 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. use*Effect*

    @japgolly
    japgolly committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    5c17b04 View commit details
    Browse the repository at this point in the history

  2. useForceUpdate take 2

    @japgolly
    japgolly committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    63c5df6 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Support useRef*

    @japgolly
    japgolly committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    a8693f4 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Remove obsolete emission test output

    @japgolly
    japgolly committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    df81d84 View commit details
    Browse the repository at this point in the history

  2. Upgrade Scala.js and re-gen all emissions

    @japgolly
    japgolly committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    17f5b09 View commit details
    Browse the repository at this point in the history

  3. Support render with reuse with children

    @japgolly
    japgolly committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    fc559e0 View commit details
    Browse the repository at this point in the history

  4. Fix Scala 2 compilation - stategy is fine 

    Only polymorphic contexts need help, otherwise type inferance works fine
(as confirmed in tests)
    @japgolly
    japgolly committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    c4cf1b3 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Re-generate all test emissions with Scala.js 1.10.1

    @japgolly
    japgolly committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    ebfd757 View commit details
    Browse the repository at this point in the history

  2. Add placeholder implementations for renderRR with reuse

    @japgolly
    japgolly committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    ad7b116 View commit details
    Browse the repository at this point in the history

  3. Support RR in render{Reusable,WithReuse,WithReuseBy}

    @japgolly
    japgolly committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    3a428e3 View commit details
    Browse the repository at this point in the history