skip copy of windows-gnu libs in check-only mode #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Ah, looks like cross stopped providing x86_64-unknown-linux-gnu binaries. |
|
Looks like using the musl binaries instead works fine. :) |
|
@jethrogb I added a test. Any objections to landing this? This PR enables check-builds of Windows GNU targets on other platforms. |
Aaron1011
reviewed
Mar 25, 2020
Co-Authored-By: Aaron Hill <[email protected]>
|
bors try |
|
I have no objections but I also have not reviewed this PR |
tryBuild succeeded |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately we cannot test
--target x86_64-pc-windows-gnuuntil rust-lang/backtrace-rs#297 lands and propagates. But I confirmed locally that using both together makes that target work on my Linux box.