Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix sensitive logging and deployment checks #2101

Merged
merged 15 commits into from
Dec 12, 2024

Conversation

subhashkhileri
Copy link
Member

@subhashkhileri subhashkhileri commented Dec 12, 2024

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHIDP-5279

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@subhashkhileri subhashkhileri requested a review from a team as a code owner December 12, 2024 02:48
@subhashkhileri
Copy link
Member Author

/test e2e-tests

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@subhashkhileri
Copy link
Member Author

/test e2e-tests

@albarbaro
Copy link
Contributor

/lgtm
/approve

Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albarbaro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 31b574e into janus-idp:main Dec 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants