Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI helper to open sidebar in config map test #2055

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

gustavolira
Copy link
Contributor

Integrated the UIhelper utility to open the "Home" sidebar in the configuration map test. This enhances the test by ensuring the correct UI state before verifying the page title, improving accuracy and reliability.

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Integrated the UIhelper utility to open the "Home" sidebar in the configuration map test. This enhances the test by ensuring the correct UI state before verifying the page title, improving accuracy and reliability.

Signed-off-by: Gustavo Lira <[email protected]>

Signed-off-by: Gustavo Lira <[email protected]>
@gustavolira gustavolira requested a review from a team as a code owner December 4, 2024 14:34
@openshift-ci openshift-ci bot requested review from josephca and psrna December 4, 2024 14:34
Copy link

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gustavolira. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Add UI helper to open sidebar in config map test". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - chore
 - docs
 - style
 - refactor
 - perf
 - test
 - revert

@kim-tsao kim-tsao merged commit df8bf7b into janus-idp:main Dec 4, 2024
4 of 10 checks passed
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants