Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): [release-1.3] update ocm_backend, regen yarn.lock to bump jsonpath-plus #1987

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

kim-tsao
Copy link
Member

Description

Please explain the changes you made here.

  • jsonpath-plus v10.2.0 bump

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@kim-tsao kim-tsao requested a review from a team as a code owner November 25, 2024 20:42
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1987!

Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fortune-Ndlovu
Copy link
Member

/test e2e-tests

@kim-tsao kim-tsao changed the title chore(deps): update ocm_backend, regen yarn.lock to bump jsonpath-plus chore(deps): [release-1.3] update ocm_backend, regen yarn.lock to bump jsonpath-plus Nov 27, 2024
@kim-tsao
Copy link
Member Author

/test e2e-tests

Copy link

openshift-ci bot commented Nov 28, 2024

@kim-tsao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 922326b link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kim-tsao
Copy link
Member Author

Manually tested the ocm (Clusters) view and verified it's functional

RHDH Version: 1.3.2
Backstage Version: 1.29.2
Last Commit: /pull/1987 @ 922326b
Build Time: 2024-11-25T20:49:53Z

@kim-tsao kim-tsao merged commit 8406a46 into janus-idp:release-1.3 Nov 28, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants