Updated the label and container port in doc on Setting up Metrics Mon… #1332
Conversation
…itoring for Operator-based deployments - Change label from janus-idp.io/app to rhdh.redhat.com/app - Correct container port from http-backend to backend
|
/cc |
There was a problem hiding this comment.
Awesome - thanks @Fortune-Ndlovu for fixing this and making sure it works as expected !!
|
/approve Doc-only PR |
|
@rm3l: rm3l unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override "PR Docker Build" |
|
@coreydaley: Overrode contexts on behalf of coreydaley: PR Docker Build In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/skip ci/prow/images |
|
@coreydaley (or anyone else) Can you |
|
instead of all the comments to disable tests, why not just merge this directly? seems more efficient... |
Indeed, I would have merged this simple PR directly, but I don't have permission on this repo. |
Why the documentation update?
In the ServiceMonitor resource to create, the label added by the Operator had changed from janus-idp.io/app to rhdh.redhat.com/app a long time ago (https://github.com/janus-idp/operator/issues/199) before the first version of the operator was released, and we forgot to update this documentation.
Also, the container port endpoint to scrape metrics from is wrong. It should be backend as per the 1.1.x, 1.2.x, or main branches in the operator repo.
As a consequence, the instructions depicted in this https://github.com/janus-idp/backstage-showcase/blob/main/showcase-docs/monitoring-and-logging.md#operator-backed-deployment will not work as expected.