Skip to content

Commit

Permalink
Merge branch 'main' into RHIDP-4244
Browse files Browse the repository at this point in the history
  • Loading branch information
schultzp2020 authored Dec 4, 2024
2 parents 5ab1ea0 + 04df020 commit f9ecd72
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
7 changes: 7 additions & 0 deletions docs/e2e-tests/CONTRIBUTING.MD
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ These principles are valid for new contributions. Some parts of the codebase may

All architecture principles and guidelines must be agreed upon by the team. Every team member's voice is important, and open communication ensures alignment and shared understanding of the project's direction.

6. **General Rules**

All tests have to follow a set of simple rules:
I. Check the preconditions. If tests are running in parallel, try to create the preconditions you need to avoid race conditions.
II. Each test has to test one and only one thing.
III. All tests have to contain preconditions, actions, and assertions, like you whould do in [Gherkin](https://cucumber.io/docs/guides/overview/); think in those terms.

#### Technical Guidelines

1. **Page Object Model (POM)**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { test, expect } from "@playwright/test";
import { KubeClient } from "../../utils/kube-client";
import { LOGGER } from "../../utils/logger";
import { Common } from "../../utils/common";
import { UIhelper } from "../../utils/ui-helper";

test.describe("Change app-config at e2e test runtime", () => {
test("Verify title change after ConfigMap modification", async ({ page }) => {
Expand Down Expand Up @@ -29,6 +30,7 @@ test.describe("Change app-config at e2e test runtime", () => {

const common = new Common(page);
await common.loginAsGuest();
await new UIhelper(page).openSidebar("Home");
LOGGER.info("Verifying new title in the UI...");
expect(await page.title()).toContain(dynamicTitle);
LOGGER.info("Title successfully verified in the UI.");
Expand Down

0 comments on commit f9ecd72

Please sign in to comment.