fix(cli): avoid packing "binary" packages [release-1.3] #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the export-dynamic-plugin command's default behavior to widen the check used to determine if an embedded dependency needs to be built. If an embedded dependency is outside of the yarn workspace and does not appear to be a source package (where "main" is a file ending in ".ts") then it will not be rebuilt during export-dynamic-plugin. This caters for cases such as a backend plugin doing a runtime import of an ESM module, the ESM module can be built and embedded into the dynamic plugin and be available on the package path at runtime. Signed-off-by: Stan Lewis <[email protected]>
🦋 Changeset detectedLatest commit: c8e2365 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gashcrumb
changed the title
|
|
/lgtm |
kim-tsao
approved these changes
Oct 16, 2024
|
This cherry pick wasn't needed after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2258
/assign gashcrumb