feat(bulk-import): use react query to fetch repositories #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
from
10350c1 to
9893604
Compare
debsmita1
changed the title
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
from
9893604 to
f17c212
Compare
🦋 Changeset detectedLatest commit: ced40be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
debsmita1
changed the title
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
from
f17c212 to
50b7960
Compare
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
from
1d94455 to
7b1dfe9
Compare
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
4 times, most recently
from
5c90994 to
acbce88
Compare
|
@debsmita1 Could you please resolve quality gate failing and merge the latest change from main . |
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
2 times, most recently
from
3e0eb14 to
2b1b7ea
Compare
christoph-jerolimov
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Hi, from the user perspective I see two issues:
- When I paginate between the pages, I always see a loading indicator.
- The order by feature works just on the current page. I expect that this issue exists before, but server-side pagination works only when the server also supports server-side ordering.
plugins/bulk-import/src/components/AddRepositories/AddRepositoriesForm.tsx
Outdated
Show resolved
Hide resolved
plugins/bulk-import/src/components/AddRepositories/AddRepositoriesForm.tsx
Outdated
Show resolved
Hide resolved
plugins/bulk-import/src/components/AddRepositories/AddRepositoriesForm.tsx
Outdated
Show resolved
Hide resolved
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
2 times, most recently
from
22cbfbc to
9996b94
Compare
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
from
9996b94 to
ced40be
Compare
|
4 tasks
|
Created PR redhat-developer/rhdh-plugins#23 , so closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
https://issues.redhat.com/browse/RHIDP-4035